Add ERB template validation to CI pipeline

.drone.yml

@@ -15,3 +15,7 @@ steps:
     - puppet-lint --no-documentation-check --no-parameter_order-check manifests/
     - puppet-lint --no-documentation-check site/
 
+- name: validatetemplates
+  image: ruby:2.5-slim
+  commands:
+    - for i in site/profile/templates/*.erb ; do erb -P -x -T '-' $i | ruby -c; done

Makefile

@@ -7,7 +7,7 @@ provision: check
 	puppet apply --config etc/puppet.conf manifests/site.pp
 
 # runs all checks on code and config
-check: puppetlint validate yamllint
+check: puppetlint validate yamllint validatetemplates
 
 # checks that puppet manifests conform to the style guide
 puppetlint:
@@ -22,6 +22,12 @@ validate:
 yamllint:
 	yamllint etc/ site/profile/
 
+# check template syntax
+validatetemplates:
+	for i in site/profile/templates/*.erb ; do \
+		erb -P -x -T '-' $$i | ruby -c ; \
+	done
+
 # deletes caches and runtime directories
 clean:
 	rm -rf cache/ var/